Merge branch 'develop' into win_pepper_cmd

pepper/cli.py

@@ -598,7 +598,7 @@ class PepperCli(object):
                     logger.error('Login token expired')
                     raise Exception('Login token expired')
             except Exception as e:
-                if e.args[0] is not 2:
+                if e.args[0] != 2:
                     logger.error('Unable to load login token from {0} {1}'.format(token_file, str(e)))
                     if os.path.isfile(token_file):
                         os.remove(token_file)

tests/requirements.txt

@@ -4,6 +4,8 @@ pytest-rerunfailures
 pytest-cov
 git+git://github.com/saltstack/pytest-salt@master#egg=pytest-salt
 tornado<5.0.0
-salt
+salt<2019.2.0
 CherryPy
 setuptools_scm
+pyzmq>=2.2.0,<17.1.0; python_version == '3.4'  # pyzmq 17.1.0 stopped building wheels for python3.4
+pyzmq>=2.2.0; python_version != '3.4'

tests/unit/test_login_details.py

@@ -20,5 +20,5 @@ def test_interactive_logins():
              MagicMock(return_value='pepper')
          ):
         result = pepper.cli.PepperCli().get_login_details()
-    assert result['SALTAPI_USER'] is 'pepper'
-    assert result['SALTAPI_PASS'] is 'pepper'
+    assert result['SALTAPI_USER'] == 'pepper'
+    assert result['SALTAPI_PASS'] == 'pepper'